kvserver: remove unnecessary condition #106061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
irfansharif
approved these changes
Jul 3, 2023
|
Uh oh, a bunch of stuff failed, maybe those are unrelated flakes but I sure am nervous they're not. Going to look into them before I proceed. |
|
I think it was just flakiness and not related to this PR, since it now passes (and I added an assertion, which doesn't fire). I have some other PR in bors that will cause a merge conflict though, so holding off a bit more. |
erikgrinaker
approved these changes
Jul 5, 2023
The `!reproposal` condition already captures whether this is the first time the proposal is seen in that method. The other condition added only fear, uncertainty, and doubt. Epic: CRDB-25287 Release note: None
tbg
force-pushed
the
address-todo-proposal
branch
from
f502712 to
6cf66d3
Compare
Removed. bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
!reproposalcondition already captures whether this is thefirst time the proposal is seen in that method. The other condition
added only fear, uncertainty, and doubt.
Epic: CRDB-25287
Release note: None